nevzheng commented on code in PR #11957:
URL: https://github.com/apache/gravitino/pull/11957#discussion_r3549398186
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergTablePropertiesMetadata.java:
##########
@@ -81,4 +99,52 @@ public class IcebergTablePropertiesMetadata extends
BasePropertiesMetadata {
protected Map<String, PropertyEntry<?>> specificPropertyEntries() {
return PROPERTIES_METADATA;
}
+
+ /**
+ * Builds the property entry for {@link #FORMAT_VERSION}, an immutable
property that accepts an
+ * unset value or one of {@link #SUPPORTED_FORMAT_VERSIONS} and defaults to
{@link
+ * #ICEBERG_DEFAULT_FORMAT_VERSION}.
+ *
+ * @return the {@code format-version} property entry.
+ */
+ private static PropertyEntry<Integer> formatVersionPropertyEntry() {
+ return new PropertyEntry.Builder<Integer>()
+ .withName(FORMAT_VERSION)
+ .withDescription(
+ "The Iceberg table format version. Valid values are 2 and 3, and
it defaults to 2 when "
+ + "unset. Version 3 is required for V3 types such as variant.")
+ .withRequired(false)
+ .withImmutable(true)
+ .withJavaType(Integer.class)
+ .withDefaultValue(ICEBERG_DEFAULT_FORMAT_VERSION)
+ .withDecoder(IcebergTablePropertiesMetadata::decodeFormatVersion)
+ .withEncoder(String::valueOf)
+ .withHidden(false)
+ .withReserved(false)
+ .build();
+ }
+
+ /**
+ * Decodes and validates a user-supplied {@link #FORMAT_VERSION} value. An
unset (null or blank)
+ * value is allowed and resolves to {@link #ICEBERG_DEFAULT_FORMAT_VERSION};
otherwise the value
+ * must be an integer in {@link #SUPPORTED_FORMAT_VERSIONS}.
+ *
+ * @param value the raw property value.
+ * @return the parsed format version, or {@link
#ICEBERG_DEFAULT_FORMAT_VERSION} when the value is
+ * unset.
+ * @throws IllegalArgumentException if the value is neither blank nor a
version in {@link
+ * #SUPPORTED_FORMAT_VERSIONS}.
+ */
+ private static Integer decodeFormatVersion(String value) {
+ if (value == null || value.trim().isEmpty()) {
Review Comment:
Good call — done. Switched to `StringUtils.isBlank(...)` here, and applied
the same to the equivalent check in `IcebergTable#rebuildCreateProperties` for
consistency. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
