Copilot commented on code in PR #11950:
URL: https://github.com/apache/gravitino/pull/11950#discussion_r3558870942
##########
web-v2/web/src/components/StyledToast.js:
##########
@@ -43,11 +43,11 @@ export default function StyledToast() {
{({ icon, message }) => (
<>
{icon}
- <div className='twc-flex twc-w-full twc-break-normal
[&>div]:twc-justify-start'>{message}</div>
- <div className='twc-flex twc-h-full'>
+ <div className='flex w-full break-normal
[&>div]:justify-start'>{message}</div>
+ <div className='flex h-full'>
{t.type !== 'loading' && (
<button
- className='twc-border-0 twc-text-[#666] twc-w-6 twc-h-6
twc-justify-start twc-rounded-full twc-ring-primary-400 twc-transition
hover:twc-bg-[#f8f8f8] focus:twc-outline-none focus-visible:twc-ring'
+ className='h-6 w-6 justify-start rounded-full border-0
text-[#666] ring-primary-400 transition hover:bg-[#f8f8f8] focus:outline-none
focus-visible:ring'
onClick={() => toast.dismiss(t.id)}
>
Review Comment:
The toast dismiss button is icon-only ("x") and currently has no accessible
label, and it also lacks an explicit `type`. Additionally, `justify-start` is a
no-op here because the button isn’t a flex container. Consider adding
`type='button'` + `aria-label` and dropping the ineffective utility to keep the
class list accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
