nevzheng commented on code in PR #11958:
URL: https://github.com/apache/gravitino/pull/11958#discussion_r3562775091
##########
api/src/main/java/org/apache/gravitino/rel/types/Type.java:
##########
@@ -78,6 +78,16 @@ enum Name {
* schema.
*/
VARIANT,
+ /**
+ * The geometry type. A geometry holds a geospatial shape (WKB-encoded) on
a planar coordinate
+ * reference system.
+ */
+ GEOMETRY,
+ /**
+ * The geography type. A geography holds a geospatial shape (WKB-encoded)
on a spheroidal
+ * coordinate reference system, with an edge-interpolation algorithm.
+ */
+ GEOGRAPHY,
Review Comment:
Geometry and geography are standard geospatial types — several catalogs and
databases support them (e.g. PostGIS, MySQL, Trino). The unified type is
catalog-neutral, so other catalogs can map to it; the Iceberg catalog is just
the first one wired.
##########
api/src/main/java/org/apache/gravitino/rel/types/Types.java:
##########
@@ -679,6 +682,168 @@ public String simpleString() {
}
}
+ /**
+ * The geometry type in Gravitino. A geometry column holds a geospatial
shape (point, line, or
+ * polygon) encoded as WKB on a planar coordinate reference system (CRS).
The CRS is carried as
+ * type metadata; Gravitino, as a catalog, does not interpret the shape
values.
+ */
+ public static class GeometryType extends Type.PrimitiveType {
+
+ /** The default coordinate reference system, matching the Iceberg/Parquet
default. */
Review Comment:
Agreed — removed the Iceberg-specific language from the API doc in 974a89668
(the default CRS/algorithm are now described by their standard values
`OGC:CRS84` / `spherical` rather than "the Iceberg/Parquet default").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
