nevzheng opened a new pull request, #11990:
URL: https://github.com/apache/gravitino/pull/11990

   ### What changes were proposed in this pull request?
   
   Clears the remaining Redocly `recommended-strict` findings that are **not** 
in the lineage schemas — five independent, low-risk fixes:
   
   1. **`datatype` `PrimitiveType`** — the `example` was an array of every type 
name, but the schema is `type: string`. Moved the enumeration into the 
`description` and gave a single valid `example: "integer"`.
   2. **`datatype` `UnparsedType`** — the example's `unparsedType` was an 
array; the property is a `string`. Fixed the example.
   3. **`policies` `UpdatePolicyContentRequest`** — the `newContent` example 
was missing the `policyType` discriminator tag its schema requires. Added 
`"policyType": "custom"`.
   4. **`tables` `AddTableColumnRequest`** — `position` and `defaultValue` 
placed `nullable` (and `default`) as siblings of a `$ref`. OpenAPI 3.0 ignores 
keywords beside a `$ref`, and the stray `nullable` (with no `type`) breaks 
example validation. Wrapped each `$ref` in `allOf` so the `description` 
attaches, and dropped the ignored keywords.
   5. **`openapi` `KerberosAuth`** — the security scheme was defined but never 
referenced (`no-unused-components`). Kerberos is a supported Gravitino 
authenticator, so it is added to the global `security` requirement rather than 
deleted.
   
   ### Why are the changes needed?
   
   These are the low-risk half of the spec-correctness backlog: three invalid 
examples, one `$ref`-sibling mistake, and one unused security scheme. Fixing 
them makes the described contract match the schemas, so examples render and 
validate and typed codegen stays clean.
   
   With this PR plus the statistics fix (#11987), the spec's 
`recommended-strict` count drops from **10 to 4**, and the **only remaining 
findings are the four lineage ones** — which are a separate, behavioral change 
tracked in the (draft) #11989. That leaves the linter one step from enforcing.
   
   Part of #11985
   
   ### Does this PR introduce _any_ user-facing change?
   
   No wire or behavior change. Examples in the rendered API docs become valid; 
`KerberosAuth` becomes a documented auth option (it was already a supported 
authenticator). No REST API, schema shape, or property-key changes.
   
   ### How was this patch tested?
   
   - `redocly lint --extends=recommended-strict` — the five targeted findings 
are cleared (10 → 5 on this branch; the 5 remaining are statistics, fixed 
separately in #11987, and the 4 lineage findings). No new findings.
   - `redocly bundle` — bundles to valid `openapi.json`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to