yuqi1129 commented on code in PR #12007:
URL: https://github.com/apache/gravitino/pull/12007#discussion_r3577182344
##########
catalogs/catalog-jdbc-postgresql/src/main/java/org/apache/gravitino/catalog/postgresql/operation/PostgreSqlTableOperations.java:
##########
@@ -689,7 +697,7 @@ private List<String> addColumnFieldDefinition(
+ col
+ PG_QUOTE
+ IS
- + addColumn.getComment()
+ + escapeSqlLiteral(addColumn.getComment(), '\'')
+ "';");
Review Comment:
Added a focused TableChange.addColumn SQL-generation regression test
covering single/double quotes and backslashes in 41967b107d.
##########
catalogs/catalog-jdbc-starrocks/src/main/java/org/apache/gravitino/catalog/starrocks/operations/StarRocksTableOperations.java:
##########
@@ -481,7 +482,10 @@ private String
addColumnFieldDefinition(TableChange.AddColumn addColumn) {
// Append comment if available
if (StringUtils.isNotEmpty(addColumn.getComment())) {
- columnDefinition.append("COMMENT
'").append(addColumn.getComment()).append("' ");
+ columnDefinition
+ .append("COMMENT '")
+ .append(escapeSqlLiteral(addColumn.getComment(), '\''))
+ .append("' ");
Review Comment:
Added a focused TableChange.addColumn SQL-generation regression test
covering single/double quotes and backslashes in 41967b107d.
##########
catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java:
##########
@@ -460,7 +461,10 @@ private String
addColumnFieldDefinition(TableChange.AddColumn addColumn) {
}
// Append comment if available
if (StringUtils.isNotEmpty(addColumn.getComment())) {
- columnDefinition.append("COMMENT
'").append(addColumn.getComment()).append("' ");
+ columnDefinition
+ .append("COMMENT '")
+ .append(escapeSqlLiteral(addColumn.getComment(), '\''))
+ .append("' ");
Review Comment:
Added a focused TableChange.addColumn SQL-generation regression test
covering single/double quotes and backslashes in 41967b107d.
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -873,7 +875,10 @@ private String
addColumnFieldDefinition(TableChange.AddColumn addColumn) {
}
// Append comment if available
if (StringUtils.isNotEmpty(addColumn.getComment())) {
- columnDefinition.append("COMMENT
'").append(addColumn.getComment()).append("' ");
+ columnDefinition
+ .append("COMMENT '")
+ .append(escapeSqlLiteral(addColumn.getComment(), '\''))
+ .append("' ");
Review Comment:
Added a focused TableChange.addColumn SQL-generation regression test
covering single/double quotes and backslashes in 41967b107d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
