nevzheng commented on PR #12011: URL: https://github.com/apache/gravitino/pull/12011#issuecomment-4971010225
@roryqi I think we should proceed with my PR. The other PR provides the basic TLS extension point, but it looks stale and currently conflicts with `main`. My PR implements the complete client-side workflow and is ready to use. | Problem / requirement | My PR #12011 | PR #10975 | |---|---|---| | Connect the V2 client over HTTPS | Supported | Supported | | Present a client certificate for mTLS | Supported through configured key stores | Requires callers to construct their own `SSLContext` | | Configure certificates without custom Java code | Environment variables | Not supported | | Load key and trust store files | Built in | Left to the caller | | Define configuration precedence | Explicit config → environment → JVM defaults | Not defined | | Validate incomplete or invalid configuration | Covered | Not covered | | Prove mTLS works end to end | Real successful and rejected TLS handshakes | Construction tests only | | Explain how users configure certificates | Client documentation included | No client workflow documentation | | Keep the implementation client-focused | Yes | Includes unrelated server/config changes | | Current repository state | Mergeable with current `main` | Stale and conflicting | The main advantage of my PR is that it delivers a usable feature, rather than only the Java API needed for someone else to build the feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
