freesinger commented on code in PR #11113:
URL: https://github.com/apache/gravitino/pull/11113#discussion_r3584216045
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java:
##########
@@ -60,6 +61,14 @@ public class LanceConfig extends Config implements
OverwriteDefaultConfig {
.stringConf()
.createWithDefault(GRAVITINO_URI);
+ public static final ConfigEntry<Boolean> INTERNAL_AUX_MODE =
Review Comment:
Removed the internal `INTERNAL_AUX_MODE` config option. auxMode now comes
from `serviceInit(...)` and is passed through the NamespaceWrapper constructor
as a field, same as the Iceberg REST service. Done.
##########
docs/lance-rest-service.md:
##########
@@ -183,13 +183,13 @@ Access the service at `http://localhost:9101`.
**Environment Variables:**
-| Environment Variable | Configuration Property
| Required | Default Value | Since Version |
-|--------------------------------------|-------------------------------------------|----------|-------------------------|---------------|
-| `LANCE_REST_NAMESPACE_BACKEND` |
`gravitino.lance-rest.namespace-backend` | Yes | `gravitino`
| 1.1.0 |
-| `LANCE_REST_GRAVITINO_METALAKE_NAME` |
`gravitino.lance-rest.gravitino-metalake` | Yes | (none)
| 1.1.0 |
-| `LANCE_REST_GRAVITINO_URI` | `gravitino.lance-rest.gravitino-uri`
| Yes | `http://localhost:8090` | 1.1.0 |
-| `LANCE_REST_HOST` | `gravitino.lance-rest.host`
| No | `0.0.0.0` | 1.1.0 |
-| `LANCE_REST_PORT` | `gravitino.lance-rest.httpPort`
| No | `9101` | 1.1.0 |
+| Environment Variable | Configuration Property
| Required | Default Value | Since Version |
+|----------------------------------------------|-------------------------------------------------------|----------|-------------------------|---------------|
+| `LANCE_REST_NAMESPACE_BACKEND` |
`gravitino.lance-rest.namespace-backend` | Yes | `gravitino`
| 1.1.0 |
+| `LANCE_REST_GRAVITINO_METALAKE_NAME` |
`gravitino.lance-rest.gravitino-metalake` | Yes | (none)
| 1.1.0 |
+| `LANCE_REST_GRAVITINO_URI` |
`gravitino.lance-rest.gravitino-uri` | Yes |
`http://localhost:8090` | 1.1.0 |
+| `LANCE_REST_HOST` | `gravitino.lance-rest.host`
| No | `0.0.0.0` | 1.1.0 |
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
