Octavi00 commented on code in PR #11812:
URL: https://github.com/apache/gravitino/pull/11812#discussion_r3592505200
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/AuthenticationFilter.java:
##########
@@ -113,7 +113,9 @@ public void doFilter(ServletRequest request,
ServletResponse response, FilterCha
// to let client to create correct authenticated request.
// Refer to
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/WWW-Authenticate
for (String challenge : ue.getChallenges()) {
- resp.setHeader(AuthConstants.HTTP_CHALLENGE_HEADER, challenge);
+ if (!challenge.toLowerCase().startsWith("basic")) {
+ resp.setHeader(AuthConstants.HTTP_CHALLENGE_HEADER, challenge);
+ }
Review Comment:
NA, was advised against using headers during 401 responses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
