mchades commented on code in PR #12098:
URL: https://github.com/apache/gravitino/pull/12098#discussion_r3614491641
##########
core/src/main/java/org/apache/gravitino/catalog/TableNormalizeDispatcher.java:
##########
@@ -52,8 +51,9 @@ public NameIdentifier[] listTables(Namespace namespace)
throws NoSuchSchemaExcep
// The constraints of the name spec may be more strict than underlying
catalog,
// and for compatibility reasons, we only apply case-sensitive
capabilities here.
Namespace caseSensitiveNs = normalizeCaseSensitive(namespace);
- NameIdentifier[] identifiers = dispatcher.listTables(caseSensitiveNs);
- return normalizeCaseSensitive(identifiers);
+ // listTables() is assumed to already return names in their canonical,
legal form, so no
+ // re-normalization is applied here.
+ return dispatcher.listTables(caseSensitiveNs);
Review Comment:
If catalog-returned identifiers must not be re-normalized because
`normalizeName()` may be non-idempotent, the same applies to `listViews()`,
`listFilesets()`, `listFunctions()`, `listModels()`, and `listTopics()`, which
still normalize their results. Please update these paths consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
