bharos commented on code in PR #12128: URL: https://github.com/apache/gravitino/pull/12128#discussion_r3635829484
########## mcp-server/tests/unit/tools/test_partition.py: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import asyncio +import unittest + +from fastmcp import Client + +from mcp_server.client.factory import RESTClientFactory +from mcp_server.core import Setting +from mcp_server.server import GravitinoMCPServer +from tests.unit.tools import MockOperation + + +class TestPartitionTool(unittest.TestCase): Review Comment: I tested the tools end-to-end against a live Gravitino through the MCP HTTP server. I only have a `iceberg` catalog available (no Hive catalog), so the calls exercised the full path and returned the expected "Table does not support partition operations" result for Iceberg (plus clean NoSuchCatalog/NoSuchSchema errors for bad inputs), all surfaced correctly as MCP isError responses. I couldn't exercise the happy path (actual partition listing) since that needs a Hive catalog. I can try to bring up one and check with hive catalog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
