jerryshao commented on code in PR #12162:
URL: https://github.com/apache/gravitino/pull/12162#discussion_r3636013006
##########
api/src/main/java/org/apache/gravitino/tag/Tag.java:
##########
@@ -54,6 +54,26 @@ public interface Tag extends Auditable {
*/
Map<String, String> properties();
+ /**
+ * @return The allowed assignment values of the tag. {@link
Optional#empty()} means the tag is
+ * unrestricted. A present empty array means the tag only accepts
valueless assignments.
+ */
+ default Optional<String[]> allowedValues() {
+ return Optional.empty();
+ }
Review Comment:
I think the definition is vague and hard to use. You use `none`, empty
arrays, and value arrays to cover three scenarios.
We'd better have a clear/separate definition for 3 scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
