Copilot commented on code in PR #11926:
URL: https://github.com/apache/gravitino/pull/11926#discussion_r3644350958
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveViewCatalogOperations.java:
##########
@@ -431,6 +443,22 @@ private SQLRepresentation validateSQLRepresentation(
defaultSchema,
ident);
return selected;
+ case Dialects.TRINO:
+ // HMS has no field to persist a Trino view's default catalog/schema,
so any value
+ // supplied here is accepted but not stored; it is not required to be
null. Unqualified
+ // identifiers in the view body will therefore fail to resolve on
reload unless the view
+ // was defined with fully-qualified references.
+ if (defaultCatalog != null || defaultSchema != null) {
+ LOG.warn(
Review Comment:
Using LOG.warn here will likely generate noisy logs during normal Trino view
creation, since Trino commonly supplies defaultCatalog/defaultSchema in
ConnectorViewDefinition. This condition is not necessarily an error (you
already accept the operation), so it should be logged at DEBUG (or at most
INFO) to avoid warning spam in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
