jerryshao commented on code in PR #12162: URL: https://github.com/apache/gravitino/pull/12162#discussion_r3663165255
########## api/src/main/java/org/apache/gravitino/tag/TagValue.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.tag; + +import com.google.common.base.Preconditions; +import java.util.Objects; +import java.util.Optional; +import javax.annotation.Nullable; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.annotation.Evolving; + +/** Represents one tag assignment value in tag association requests. */ +@Evolving +public final class TagValue { + + private final String name; + + @Nullable private final String value; + + private TagValue(String name, @Nullable String value) { + this.name = name; + this.value = value; + } + + /** + * Creates a valued tag assignment value. + * + * @param name The tag name. + * @param value The assignment value. + * @return The tag value. + */ + public static TagValue of(String name, String value) { + Preconditions.checkArgument(StringUtils.isNotBlank(name), "Tag name must not be blank"); + Preconditions.checkArgument(StringUtils.isNotBlank(value), "Tag value must not be blank"); + return new TagValue(name, value); + } + + /** + * Creates a valueless tag assignment value. + * + * @param name The tag name. + * @return The tag value. + */ + public static TagValue valueless(String name) { Review Comment: Valueless means "no worth, not important", it doesn't mean no value. You can change to `noValue` for simplicity. or `ofNoValue`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
