lasdf1234 commented on code in PR #12194:
URL: https://github.com/apache/gravitino/pull/12194#discussion_r3663851959
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -82,9 +89,21 @@ public class CatalogWrapperForREST extends
IcebergCatalogWrapper {
private final ScanPlanCache scanPlanCache;
+ /** Maximum number of file scan tasks handed out inline by one scan planning
response. */
+ private final int scanPlanTaskBatchSize;
+
private static final String DATA_ACCESS_VENDED_CREDENTIALS =
"vended-credentials";
private static final String DATA_ACCESS_REMOTE_SIGNING = "remote-signing";
+ /**
+ * Total order over file scan tasks, so that plan-task tokens, which address
tasks by position,
+ * keep pointing at the same tasks when a plan is recomputed.
+ */
+ private static final Comparator<FileScanTask> FILE_SCAN_TASK_ORDER =
Review Comment:
FILE_SCAN_TASK_ORDER is only used once — consider inlining the comparator at
the sort call site to avoid the extra constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
