mchades commented on code in PR #11926:
URL: https://github.com/apache/gravitino/pull/11926#discussion_r3664069313
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveView.java:
##########
@@ -109,18 +134,23 @@ public AuditInfo auditInfo() {
}
/**
- * Detects the SQL dialect from HMS table properties and view text.
+ * Detects the SQL dialect from HMS table properties.
*
- * @param viewOriginalText The original view text from HMS.
* @param parameters The HMS table parameters map.
* @return The detected dialect string: "trino", "spark", "flink", or "hive".
+ * @throws UnsupportedOperationException if the view was created by a native
Presto/Trino Hive
+ * connector (bypassing Gravitino); its encoded body cannot be read as
SQL by any engine.
Review Comment:
we should decode the body and return the Trino dialect view SQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
