yuqi1129 commented on code in PR #12271:
URL: https://github.com/apache/gravitino/pull/12271#discussion_r3681708941
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueIcebergTableHelper.java:
##########
@@ -189,6 +190,20 @@ static Catalog createGlueCatalog(Map<String, String>
config) {
return glueCatalog;
}
+ @VisibleForTesting
+ static boolean validateAwsStaticCredential(String accessKey, String
secretKey) {
Review Comment:
We'd better improve the readability here. `validateAwsStaticCredential`
means that we will check the validity of `accessKey` and `secretKey`. In the
normal course of events, `true` means it's okay and `false` means it's invalid.
However, when both `accessKey` and `secretKey` are empty, the check result is
`true`, but the return value is `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
