jerryshao commented on PR #12257: URL: https://github.com/apache/gravitino/pull/12257#issuecomment-5165055028
Hi @nevzheng , I did a cursory review about the current design doc. Looks like your solution is to introduce a generic soft deletion for all the entities, not just for Iceberg alone. Also, your design is focus on the Gravitino API, not the IRC API. I have several questions: 1. Is it meaningful to add soft deletion support to some data source catalogs that don't have a soft deletion mechanism? For example, like the Hive catalog, what is the behavior after we support the Hive table's soft deletion? I can think of one solution is to only make it invisible from Gravitino side. But it also leaves an inconsistency from Hive's perspective. 2. If we want to support generic soft deletion, shall we expand the scope to not just the table, but also other entities? These two are fundamental decision questions that we should think carefully about. From my point, I think it is not so necessary to extend to non-IRC scope unless we have a clear requirement. We can focus on IRC alone to implement an IRC-only feature like what we did before for async hard deletion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
