roryqi commented on code in PR #12366:
URL: https://github.com/apache/gravitino/pull/12366#discussion_r3718493031
##########
api/src/main/java/org/apache/gravitino/file/FilesetCatalog.java:
##########
@@ -122,11 +126,36 @@ default Fileset createMultipleLocationFileset(
String comment,
Fileset.Type type,
Map<String, String> storageLocations,
- Map<String, String> properties)
+ Map<String, String> properties,
+ Map<String, Map<String, String>> secretBindings,
Review Comment:
We should define `SecretBindings` here instead of using a Map.
For example,
```
class SecretBinding {
string name;
String provider;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
