yuqi1129 commented on PR #12350:
URL: https://github.com/apache/gravitino/pull/12350#issuecomment-5190114154
@roryqi
Thanks for the suggestion. I understand it as extracting a common OCC SQL
template for update/fence/soft-delete operations, with each provider supplying
the table name, ID column, and MyBatis parameter names. After reviewing these
statements, I think a generic SQL template would have limited benefit here.
Besides the table and ID column, the MyBatis parameter paths, batch collection
names, entity-specific SET clauses, and database-specific deleted_at
expressions also differ. Passing these as string parameters would hide the
final SQL, reduce readability, and move some errors to runtime. I would prefer
to keep the entity-specific SQL explicit.
I agree that exact duplication should be removed. A narrower approach would
be to reuse DatabaseTimeSQL for database-time expressions and let PostgreSQL
providers inherit SQL that is identical to the base provider, keeping overrides
only where the SQL dialect actually differs. If more entities later converge on
an identical OCC SQL shape, we can revisit a narrowly scoped helper. Would this
narrower cleanup address your concern, or do you have a specific
interface/template design in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
