markhoerth commented on PR #12360: URL: https://github.com/apache/gravitino/pull/12360#issuecomment-5200164162
I dont think so. The standard allows customized and vendor specific fields. On Wed, Aug 5, 2026 at 8:42 PM Jerry Shao ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In design-docs/gravitino-metric-view-design.md > <https://github.com/apache/gravitino/pull/12360#discussion_r3725733500>: > > > +CustomExtension > + vendor_name: string > + data: string > + > +Dialect = "ANSI_SQL" | "SNOWFLAKE" | "MDX" | "TABLEAU" > + | "DATABRICKS" | "MAQL" | "BIGQUERY" > +``` > + > +- Each `Expression` contains at least one `DialectExpression`. > +- Every dialect entry uses a supported `Dialect`. > +- Every dialect entry has a non-empty `expression`. > +- `Dimension`, `AIContext`, and `CustomExtension` values satisfy the structures above. > + > +The required `MetricModel.name` is independent of the enclosing View name. This preserves semantic-model identity across imports and View renames. > + > +Every supported `custom_extensions` array is retained losslessly. Unknown standardized fields are rejected until the declared OSI profile supports them. > > "Unknown standardized fields are rejected until the declared OSI profile > supports them." > > Is this the OSI's behavior? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/gravitino/pull/12360?email_source=notifications&email_token=ALNHCVXJJKSCL5OG3OIUATT5IP5BBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBXGA3TMOBTHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4870768383>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALNHCVR7SL4L6WNJVBAE2V35IP5BBAVCNFSNUABFKJSXA33TNF2G64TZHM3DGMJUGMYTANRRHNEXG43VMU5TKMBWGEYTGNZSGE22C5QC> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/ALNHCVWZ5XQ7G3VHM3TBUOD5IP5BBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBXGA3TMOBTHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/ALNHCVUG2E3LYDIRKSQD5ZL5IP5BBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBXGA3TMOBTHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
