lasdf1234 commented on code in PR #12366:
URL: https://github.com/apache/gravitino/pull/12366#discussion_r3734441269
##########
api/src/main/java/org/apache/gravitino/file/FilesetCatalog.java:
##########
@@ -113,6 +116,10 @@ default Fileset createFileset(
* @param type The type of the fileset.
* @param storageLocations The location names and storage locations of the
fileset.
* @param properties The properties of the fileset.
+ * @param secretBindings optional property key → binding ({@code provider} +
{@code plaintext})
Review Comment:
Got. createFileset has new method sign with parameter 'secretReferences' and
'secretBindings'
##########
design-docs/gravitino-entity-secrets.md:
##########
@@ -650,12 +650,12 @@ sibling maps). Existing **`setProperty`** stays a
**string** `value` (plaintext
| `@type` | Fields (flat; not nested under `value`)
| Behavior
|
| -------------------- |
----------------------------------------------------------------------------------------
|
---------------------------------------------------------------------------------------------------------------------------------------------------------
|
| `setProperty` | `value` (**string** plaintext)
| Today’s plaintext set. If the **current**
value matches the URN recognition rule, in-place `writeSecret` via provider in
the current URN; persist new URN |
-| `setSecretBinding` | `provider` (instance name) + `value` (plaintext
string) | Write-through bind/re-bind
(`writeSecret`); persist returned URN
|
+| `setSecretBinding` | `provider` (instance name) + `plaintext` (plaintext
string) | Write-through bind/re-bind
(`writeSecret`); persist returned URN
|
Review Comment:
Got document has been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
