diqiu50 commented on code in PR #12294: URL: https://github.com/apache/gravitino/pull/12294#discussion_r3764396569
########## docs/apache-hive-catalog.md: ########## @@ -241,9 +241,11 @@ Support for altering partitions is under development. - Supports list, create, load, alter, and drop for views stored in the Hive Metastore Service as `VIRTUAL_VIEW`. - Each view must contain exactly one SQL representation. -- Supports creating views with the `hive`, `flink`, or `spark` dialect. -- When loading an existing HMS view, Gravitino automatically detects whether the view uses the `hive`, `flink`, `spark`, or `trino` dialect. +- Supports creating views with the `hive`, `trino`, `flink`, or `spark` dialect. +- When loading an existing HMS view, Gravitino automatically detects whether the view uses the `hive`, `trino`, `flink`, or `spark` dialect. - For the `hive` and `flink` dialects, `defaultCatalog` and `defaultSchema` must be `null`. +- For the `trino` dialect, `defaultSchema` requires `defaultCatalog` to also be set (a schema without a catalog cannot be represented). +- The `trino` dialect requires at least one output column, and is stored using Trino's own native "Presto View" Hive Metastore encoding, so a view created through Gravitino is interoperable with a native Trino/Presto Hive connector pointed at the same Hive Metastore, and vice versa. The HMS `presto_view` property this relies on is reserved and managed internally based on the view's dialect; it cannot be set or removed directly. Gravitino's view model cannot represent a native Trino view's owner, `runAsInvoker`, or SQL path, so replacing an existing native view that has a non-default value for any of them is rejected rather than silently discarding it. Review Comment: Integration tests in the next PR #11926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
