yuqi1129 commented on code in PR #12199:
URL: https://github.com/apache/gravitino/pull/12199#discussion_r3749712620
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/config/COSCredentialConfig.java:
##########
@@ -58,11 +59,63 @@ public class COSCredentialConfig extends Config {
.checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
+ public static final ConfigEntry<String> COS_ROLE_ARN =
+ new ConfigBuilder(COSProperties.GRAVITINO_COS_ROLE_ARN)
+ .doc("The CAM role ARN that the server assumes when issuing STS
temporary credentials")
Review Comment:
What's the meaning of `CAM` here?
##########
bundles/tencent/src/main/java/org/apache/gravitino/cos/credential/policy/Condition.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.cos.credential.policy;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+/** Tencent Cloud CAM policy condition operator wrapper. Currently only {@code
string_like}. */
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public class Condition {
+
+ @JsonProperty("string_like")
+ private StringLike stringLike;
+
+ private Condition(Builder builder) {
+ this.stringLike = builder.stringLike;
+ }
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ public static class Builder {
+ private StringLike stringLike;
+
+ public Builder stringLike(StringLike stringLike) {
+ this.stringLike = stringLike;
+ return this;
+ }
+
+ public Condition build() {
+ return new Condition(this);
+ }
+ }
+
+ @SuppressWarnings("unused")
+ public StringLike getStringLike() {
Review Comment:
Why can't we just remove it?
##########
docs/security/credential-vending.md:
##########
@@ -11,16 +11,16 @@ Gravitino credential vending is used to generate temporary
or static credentials
## Supported Catalogs
-| Catalog type | Vends |
-|--------------|---------------------------------|
-| Fileset | S3, OSS, GCS, ADLS |
-| Hive | S3, OSS, GCS, ADLS |
-| Iceberg | S3, OSS, GCS, ADLS |
-| Glue | S3 |
-| JDBC | JDBC user and password |
-| Paimon | S3, OSS, JDBC user and password |
+| Catalog type | Vends |
+|--------------|--------------------------------------|
Review Comment:
Remove redundant space in the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
