lasdf1234 commented on code in PR #12420:
URL: https://github.com/apache/gravitino/pull/12420#discussion_r3782048769
##########
clients/client-java/src/main/java/org/apache/gravitino/client/BaseSchemaCatalog.java:
##########
@@ -167,20 +171,35 @@ public String[] listSchemas(String parentSchema)
}
/**
- * Create a new schema with specified identifier, comment and metadata.
+ * Create a new schema with specified identifier, comment, properties, and
optional secret maps.
*
* @param schemaName The name identifier of the schema.
* @param comment The comment of the schema.
* @param properties The properties of the schema.
+ * @param secretBindings Optional property key → binding ({@code provider} +
{@code plaintext})
+ * for write-through.
+ * @param secretReferences Optional property key → secret locator ({@code
provider} plus
+ * provider-specific attributes).
* @return The created {@link Schema}.
* @throws NoSuchCatalogException if the catalog with specified namespace
does not exist.
* @throws SchemaAlreadyExistsException if the schema with specified
identifier already exists.
*/
@Override
- public Schema createSchema(String schemaName, String comment, Map<String,
String> properties)
Review Comment:
Thank you for your review. This issue has been fixed.
##########
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java:
##########
@@ -137,9 +139,13 @@ public Catalog createCatalog(
Catalog.Type type,
String provider,
String comment,
- Map<String, String> properties)
+ Map<String, String> properties,
+ Map<String, SecretBinding> secretBindings,
+ Map<String, SecretReference> secretReferences)
throws NoSuchMetalakeException, CatalogAlreadyExistsException {
- return getMetalake().createCatalog(catalogName, type, provider, comment,
properties);
+ return getMetalake()
Review Comment:
Thank you for your review. This issue has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
