roryqi commented on code in PR #11634:
URL: https://github.com/apache/gravitino/pull/11634#discussion_r3791243717
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -181,6 +181,20 @@ public LoadCredentialsResponse getTableCredentials(
}
}
+ /**
+ * Whether this catalog wrapper supports server-side scan planning.
+ *
+ * <p>Gravitino implements scan planning locally on top of loaded table
metadata. For non-REST
+ * backends (Hive, JDBC, Memory, Custom) this always works. For REST
backends the upstream catalog
+ * owns scan planning; advertising the endpoint here could be misleading
when the upstream does
+ * not support it, so we do not advertise it.
+ *
+ * @return {@code true} if the scan-plan endpoint should be advertised
+ */
+ public boolean supportsScanPlanOperations() {
Review Comment:
Agree with you. Option 2 seems better. You can continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
