yuqi1129 commented on PR #12364: URL: https://github.com/apache/gravitino/pull/12364#issuecomment-5322222002
> @yuqi1129 That makes sense, thanks for taking another look. I agree this is an improvement rather than a bug fix, and I take the point about not changing database scripts in patch releases. > > I have narrowed the PR to 2.0.0 only — the 1.3.1 schema and the two related upgrade scripts are gone. What is left is two files: > > * `schema-2.0.0-mysql.sql` — the index renames and the `table_version_info` primary key > * `upgrade-1.3.0-to-2.0.0-mysql.sql` — the same two changes appended to the existing content, which is unchanged > > The upgrade script needs to stay in sync, otherwise a database upgraded from 1.3.0 would keep the old index names and a `table_version_info` without a primary key. I verified that applying it to `schema-1.3.0-mysql.sql` yields exactly the index names and primary keys declared in `schema-2.0.0-mysql.sql`. > > For our 1.3.0 deployment we will maintain the migration internally, as you suggested. Thanks also for the 2.0.0 timeline and the Lance roadmap. > > This should be ready for another look. Great, I will review and merge it ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
