lasdf1234 commented on code in PR #12489:
URL: https://github.com/apache/gravitino/pull/12489#discussion_r3803641696
##########
common/src/testFixtures/java/org/apache/gravitino/encryption/kms/FakeKmsClient.java:
##########
@@ -25,23 +25,19 @@
/** In-memory KMS client for contract and consumer tests. */
public final class FakeKmsClient implements KmsClient {
- private final String api;
- private final String source;
+ private final String provider;
private final Map<String, KeyState> keys = new HashMap<>();
/**
* Creates an empty fake client.
*
- * @param api exact KMS API identifier accepted by the client; lowercase
kebab-case with no
- * surrounding whitespace
- * @param source configured source accepted by the client
+ * @param provider configured provider accepted by the client
*/
- public FakeKmsClient(String api, String source) {
- this.api = KmsApiIdentifiers.requireValid(api);
- if (source == null || source.trim().isEmpty()) {
- throw new IllegalArgumentException("KMS source cannot be blank");
+ public FakeKmsClient(String provider) {
+ if (provider == null || provider.trim().isEmpty()) {
+ throw new IllegalArgumentException("KMS provider cannot be blank");
Review Comment:
May be Stringutils is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
