jerryshao commented on code in PR #12497:
URL: https://github.com/apache/gravitino/pull/12497#discussion_r3809285063
##########
api/src/main/java/org/apache/gravitino/job/JobHandle.java:
##########
@@ -69,4 +71,13 @@ enum Status {
* @return the status of the job
*/
Status jobStatus();
+
+ /**
+ * Get the time when the job finished execution.
+ *
+ * @return the finished time of the job, or null if the job has not finished
execution yet
+ */
+ default Instant finishedAt() {
Review Comment:
Good catch, added `@Nullable` in 4f85fd94d.
##########
api/src/main/java/org/apache/gravitino/job/JobHandle.java:
##########
@@ -69,4 +71,13 @@ enum Status {
* @return the status of the job
*/
Status jobStatus();
+
+ /**
+ * Get the time when the job finished execution.
+ *
+ * @return the finished time of the job, or null if the job has not finished
execution yet
+ */
+ default Instant finishedAt() {
Review Comment:
Added `@Nullable` to both `JobInfo.finishedAt()` and
`JobEntity.finishedAtAsInstant()` as well, in 4f85fd94d.
##########
docs/open-api/jobs.yaml:
##########
@@ -514,6 +514,10 @@ components:
- "canceled"
audit:
$ref: "./openapi.yaml#/components/schemas/Audit"
+ finishedAt:
+ type: string
+ format: date-time
+ description: The time when the job finished execution, or absent if
the job has not finished execution yet
Review Comment:
Good catch, added `nullable: true` and updated the description to match the
actual wire behavior, in 4f85fd94d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
