yuqi1129 commented on code in PR #12543:
URL: https://github.com/apache/gravitino/pull/12543#discussion_r3829063177
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -359,6 +520,13 @@ public String getCatalogConnectorFactoryClassName() {
public String toCatalogConfig() {
List<String> stringList = new ArrayList<>();
for (Map.Entry<String, ConfigEntry> entry : CONFIG_DEFINITIONS.entrySet())
{
+ // The `trino.jdbc.*` configurations are only used by the coordinator to
connect back to
+ // Trino. They must not be propagated to the dynamic catalogs, otherwise
credentials such as
+ // the JDBC password and the truststore password would end up in the
generated CREATE CATALOG
+ // statement, which is logged and persisted into the Trino catalog
properties files.
+ if (entry.getKey().startsWith(TRINO_JDBC_CONFIG_PREFIX)) {
Review Comment:
Can you confirm the fact that when the coordinator restarts and the dynamic
catalog loads before the static catalog, the trino.jdbc.* no longer propagates
will cause the JDBC connection to lose the username/password /TLS configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
