diqiu50 opened a new pull request, #12555:
URL: https://github.com/apache/gravitino/pull/12555

   ### What changes were proposed in this pull request?
   
   The Trino connector builds an internal Iceberg REST catalog pointing at the 
Gravitino Iceberg REST server for every `lakehouse-iceberg` catalog, instead of 
translating `catalog-backend` into Trino's `jdbc` or `hive_metastore` catalog 
type.
   
   Three connector-level properties, configured once per Trino cluster:
   
   - `gravitino.iceberg.rest-enabled` (default `true`)
   - `gravitino.iceberg.rest-uri`
   - `gravitino.iceberg.rest-catalog.` — prefix rewritten to 
`iceberg.rest-catalog.`, carrying the IRC's authentication
   
   Everything else is derived from the catalog. A catalog with 
`catalog-backend=rest` is not re-routed.
   
   ### Why are the changes needed?
   
   `credential-providers=s3-token` is silently non-functional on this path.
   
   Fix: #12554
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Three new connector properties, and a breaking change: 
`gravitino.iceberg.rest-enabled` defaults to `true`, so on upgrade a metalake 
with `catalog-backend=jdbc` or `hive` Iceberg catalogs fails to load them 
unless `gravitino.iceberg.rest-uri` is set, or the switch is turned off. Needs 
a release note.
   
   Docs updated under `docs/trino-connector/`.
   
   ### How was this patch tested?
   
   Unit tests: 148 pass, 13 new.
   
   Integration test: the existing `lakehouse-iceberg` testset runs over the new 
path, 24/24 pass across a hive-backend and a jdbc-backend catalog.
   
   Not verified: end-to-end s3-token vending. The test warehouse is HDFS, which 
skips credential generation, so no STS credential is actually issued. This 
needs a real AWS account.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to