zhang-arvin commented on PR #12503: URL: https://github.com/apache/gravitino/pull/12503#issuecomment-5372665265
@mchades Thanks for the review. I have addressed most of the comments in the latest push: - ✅ **SQL providers**: Added VIEW and FUNCTION to `softDeletePolicyMetadataObjectRelsByCatalogId` / `softDeletePolicyMetadataObjectRelsBySchemaIds` in both BaseSQLProvider and PostgreSQLProvider - ✅ **Test entity persistence**: Persisted ViewEntity and FunctionEntity in TestPolicyManager fixture - ✅ **API docs**: Updated `docs/open-api/policies.yaml` (added VIEW and FUNCTION to MetadataObject enum) and `docs/policies.md` (removed the outdated statement that views/functions cannot carry a policy) - 🔄 **Integration tests**: Working on adding integration test coverage for the new metadata object types. Will push shortly. Please let me know if the current changes look good or if any adjustments are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
