mchades commented on code in PR #12553:
URL: https://github.com/apache/gravitino/pull/12553#discussion_r3843991947
##########
catalogs/catalog-kafka/src/main/java/org/apache/gravitino/catalog/kafka/KafkaCatalogOperations.java:
##########
@@ -185,12 +184,7 @@ public NameIdentifier[] listTopics(Namespace namespace)
throws NoSuchSchemaExcep
}
@Override
- public void testConnection(
- NameIdentifier catalogIdent,
- Catalog.Type type,
- String provider,
- String comment,
- Map<String, String> properties) {
+ public void testConnection(NameIdentifier catalogIdent) {
try {
Review Comment:
This is already bounded by the Kafka catalog configuration. `initialize()`
forwards all `gravitino.bypass.*` properties to the `AdminClient`, and the
shipped `kafka.conf` sets both `request.timeout.ms` and
`default.api.timeout.ms` to `15000`. `CatalogManager` merges these defaults for
pre-creation tests and catalog creation, so the future uses a 15-second timeout
rather than the Kafka 60-second default. This behavior was introduced in #3417
specifically to shorten Kafka failures. I suggest keeping `testConnection`
aligned with the configured AdminClient timeout for the catalog instead of
adding a separate hard-coded timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
