Copilot commented on code in PR #12587:
URL: https://github.com/apache/gravitino/pull/12587#discussion_r3854644492


##########
core/src/main/java/org/apache/gravitino/storage/relational/JDBCBackend.java:
##########
@@ -539,6 +539,9 @@ public int hardDeleteLegacyData(Entity.EntityType 
entityType, long legacyTimelin
         return ViewMetaService.getInstance()
             .deleteViewMetasByLegacyTimeline(
                 legacyTimeline, GARBAGE_COLLECTOR_SINGLE_DELETION_LIMIT);
+      case SEMANTIC_MODEL:
+        // TODO: Delegate to SemanticModelMetaService when relational 
persistence is added.
+        return 0;

Review Comment:
   TODO comments should include an issue reference so follow-up work is 
trackable (per project guidelines).
   
   This issue also appears on line 585 of the same file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to