diqiu50 commented on code in PR #12581:
URL: https://github.com/apache/gravitino/pull/12581#discussion_r3860662497
##########
core/src/main/java/org/apache/gravitino/catalog/OperationDispatcher.java:
##########
@@ -277,6 +277,14 @@ private <T> Map<String, String> getPropertiesForSet(T...
t) {
} else if (item instanceof ViewChange.SetProperty) {
ViewChange.SetProperty setProperty = (ViewChange.SetProperty) item;
properties.put(setProperty.getProperty(), setProperty.getValue());
+ } else if (item instanceof
org.apache.gravitino.model.ModelChange.SetProperty) {
Review Comment:
FQN
##########
core/src/test/java/org/apache/gravitino/catalog/TestOperationDispatcher.java:
##########
@@ -158,8 +159,15 @@ void testProperties(Map<String, String> expectedProps,
Map<String, String> testP
(k, v) -> {
Assertions.assertEquals(v, testProps.get(k));
});
- Assertions.assertFalse(testProps.containsKey(StringIdentifier.ID_KEY));
- Assertions.assertFalse(testProps.containsKey(TEST_FILESET_HIDDEN_KEY));
+ // If a hidden key is present, it must be masked (never plaintext).
+ if (testProps.containsKey(StringIdentifier.ID_KEY)) {
+ Assertions.assertEquals(
+ HiddenPropertyMaskUtils.MASKED_VALUE,
testProps.get(StringIdentifier.ID_KEY));
+ }
Review Comment:
We can replace if (xxx) { assert(xxx); } with Assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
