mchades commented on code in PR #12602: URL: https://github.com/apache/gravitino/pull/12602#discussion_r3871581645
########## core/src/main/java/org/apache/gravitino/storage/relational/service/SemanticModelPOStorageOps.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.storage.relational.service; + +import java.util.Locale; +import org.apache.gravitino.Entity; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.exceptions.NoSuchEntityException; +import org.apache.gravitino.storage.relational.mapper.SemanticModelMetaMapper; +import org.apache.gravitino.storage.relational.po.SemanticModelPO; + +/** Provides relational persistent-object operations required to create and load Semantic Models. */ +public class SemanticModelPOStorageOps + extends BasePOStorageOps<SemanticModelPO, SemanticModelMetaMapper> { + + /** Creates Semantic Model persistent-object operations. */ + public SemanticModelPOStorageOps() {} + + @Override + public void insertPO( + SemanticModelMetaMapper mapper, SemanticModelPO semanticModelPO, boolean overwrite) { + if (overwrite) { + mapper.insertSemanticModelMetaOnDuplicateKeyUpdate(semanticModelPO); + } else { + mapper.insertSemanticModelMeta(semanticModelPO); + } + } + + @Override + public SemanticModelPO getPO( + SemanticModelMetaMapper mapper, Long parentId, String semanticModelName) { + return mapper.selectSemanticModelMetaBySchemaIdAndName(parentId, semanticModelName); + } + + @Override + public SemanticModelPO getPOByFullName( + SemanticModelMetaMapper mapper, NameIdentifier identifier) { + Namespace namespace = identifier.namespace(); + SemanticModelPO po = + mapper.selectSemanticModelByFullQualifiedName( + namespace.level(0), namespace.level(1), namespace.level(2), identifier.name()); + if (po == null) { + throw new NoSuchEntityException( + NoSuchEntityException.NO_SUCH_ENTITY_MESSAGE, + Entity.EntityType.CATALOG.name().toLowerCase(Locale.ROOT), + namespace.level(1)); Review Comment: The expected assertions here depend on the metalake-vs-catalog classification discussed in the [related thread](https://github.com/apache/gravitino/pull/12602#discussion_r3870624155). The current full-name and cache-enabled parent-ID lookup paths both classify a missing metalake or catalog as a missing catalog. Tests expecting distinct classifications would be inconsistent with those paths, while asserting the current ambiguous result would lock it in as a Semantic Model-specific contract. I am not adding either expectation in this PR; targeted classification tests should accompany a consistent cross-entity relational lookup change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
