jerryshao opened a new issue, #12872:
URL: https://github.com/apache/gravitino/issues/12872

   ### Version
   
   main branch
   
   ### Describe what's wrong
   
   Audit log entries record the request path and operation type, but not the 
request parameters. On endpoints where a parameter controls how much or what 
kind of data is returned, two calls to the same endpoint that return very 
different amounts of information produce identical audit entries (same 
operation, same object, same result) apart from the timestamp. This makes it 
impossible to reconstruct after the fact what a given call actually returned.
   
   The same gap shows up on failed requests: the audit entry records the 
request URI but the query string is stripped, so a failed call is 
indistinguishable from another failed call to the same path with different 
parameters.
   
   ### Error message and/or stacktrace
   
   N/A — this is a logging-completeness gap, not a crash or exception.
   
   ### How to reproduce
   
   Issue two requests to any endpoint whose response scope depends on a query 
parameter (e.g., a listing endpoint with an optional detail/expansion flag), 
differing only in that parameter's value. Compare the resulting audit log 
entries — they are identical except for the timestamp, even though the two 
responses differ materially in content.
   
   ### Additional context
   
   This should be scoped deliberately: the fix is not "log the full raw query 
string" (some parameters may carry sensitive values), but rather ensure that 
audit entries capture the specific parameters that affect the scope or 
sensitivity of a response. Aside from this gap, audit logging otherwise behaves 
correctly — authentication failures are recorded, and successful operations 
carry principal, operation, object, and source address.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to