jerryshao commented on code in PR #12891:
URL: https://github.com/apache/gravitino/pull/12891#discussion_r3931373180
##########
server-common/src/main/java/org/apache/gravitino/server/web/RequestContextFilter.java:
##########
@@ -28,24 +32,52 @@
import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
import org.apache.commons.lang3.StringUtils;
+import org.apache.gravitino.audit.AuditLogRedactor;
Review Comment:
Checked this before changing anything: this project doesn't have a separate
`checkstyleMain`/checkstyle Gradle task — the closest equivalent is Spotless's
`removeUnusedImports()` step (configured in the root `build.gradle.kts`). I ran
`./gradlew :server-common:compileJava` (clean, `--rerun`) and `./gradlew
:server-common:spotlessApply` against this exact file with the import present:
compilation succeeds with no warning, and `spotlessApply` leaves the import
untouched (it doesn't strip it as unused, since it's referenced from the
`{@link AuditLogRedactor}` Javadoc tags on lines 51 and 53).
Per this repo's CLAUDE.md ("Always use normal import statements instead of
Fully Qualified Class Names (FQN)... unless there is a real class name
conflict"), I'd rather keep the import than switch to an FQN in the Javadoc for
a case that doesn't reproduce. Happy to revisit if this actually fails in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
