laserninja commented on PR #11216:
URL: https://github.com/apache/gravitino/pull/11216#issuecomment-5564084499
@ibrahimErbilen thanks for this work. Since the branch had been idle for a
while and had drifted from `main`, I have opened #12937 to carry it forward so
#11196 can land.
Your two commits are preserved there with your authorship intact, and you
are credited as co-author on the follow-up commit, so the squashed merge will
attribute it to you as well. On top of the rebase I addressed the review
comments here: the `ImmutableList.of(...)` paren that broke compilation, the
import ordering, the coupling to `IcebergRewriteDataFilesJob`
(`IcebergJobUtils` has since landed on `main` and now provides those helpers),
the unresolved `{{use_caching}}` placeholder being forwarded as a literal
value, the `int` vs `long` procedure output, and the test method name. I also
added a docs section for the new template.
Happy to hand this back if you would rather finish it yourself - just say so
and I will close mine. Otherwise this one can be closed in favour of #12937.
Review comments on the new PR are very welcome either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
