yuqi1129 commented on PR #12968: URL: https://github.com/apache/gravitino/pull/12968#issuecomment-5577601222
Thanks for the fix. I suggest keeping only the PostgreSQL changes in this PR and discussing the MySQL changes separately. The MySQL checks can avoid creating the same index again, but other statements, such as ADD COLUMN and DROP INDEX, can still fail when we run the script again. So the extra SQL does not yet solve the upgrade retry problem. Could we first clarify which retry case we want to support? For the test, please check that the indexes exist and have the expected columns and uniqueness. If we only want to test running the index statements twice, please make that scope clear. Ignoring errors from other DDL statements does not show that the whole upgrade script can be run again safely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
