jerryshao commented on code in PR #12946:
URL: https://github.com/apache/gravitino/pull/12946#discussion_r3954326638
##########
core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java:
##########
@@ -108,11 +95,7 @@ public Counter getCounter(String name) {
*/
public Histogram getHistogram(String name) {
return this.metricRegistry.histogram(
- name,
- () ->
- new Histogram(
- new SlidingTimeWindowArrayReservoir(
- getTimeSlidingWindowSeconds(), TimeUnit.SECONDS)));
+ name, () -> new Histogram(new ExponentiallyDecayingReservoir()));
Review Comment:
That's still the limitation. Using `ExponentiallyDecayingReservoir` can
mitigate this problem, but cannot fully solve it.
In the production environment, I think this is not a real problem. I assume
that the server will not be idle for a long time in the production environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
