roryqi commented on code in PR #12959:
URL: https://github.com/apache/gravitino/pull/12959#discussion_r3955269133
##########
catalogs/catalog-common/src/test/java/org/apache/gravitino/lakehouse/iceberg/TestIcebergPropertiesUtils.java:
##########
@@ -23,11 +23,18 @@
import java.util.Map;
import org.apache.gravitino.catalog.lakehouse.iceberg.IcebergConstants;
import org.apache.gravitino.catalog.lakehouse.iceberg.IcebergPropertiesUtils;
+import org.apache.gravitino.storage.AzureProperties;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
public class TestIcebergPropertiesUtils {
+ private static final String ADLS_TOKEN_CREDENTIAL_PROVIDER =
"adls.token-credential-provider";
+ private static final String ADLS_TOKEN_CREDENTIAL_PROVIDER_PREFIX =
+ ADLS_TOKEN_CREDENTIAL_PROVIDER + ".";
+ private static final String AZURE_CLIENT_SECRET_TOKEN_CREDENTIAL_PROVIDER =
+
"org.apache.gravitino.iceberg.common.credential.AzureClientSecretTokenCredentialProvider";
Review Comment:
Good catch. I moved these shared values to IcebergConstants and reused them
in both the production code and tests in a408c63358.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
