yuqi1129 commented on code in PR #13078: URL: https://github.com/apache/gravitino/pull/13078#discussion_r3977886976
########## docs/trino-connector/catalog-iceberg.md: ########## @@ -111,10 +111,17 @@ Four keys are reserved: `iceberg.rest-catalog.uri`, `.warehouse`, `.prefix` and `gravitino.iceberg.rest-catalog.` or a catalog's `trino.bypass.` has no effect — the connector logs when it ignores one. -When `gravitino.client.session.forwardUser=true`, the connector also sets -`iceberg.rest-catalog.session=USER` so that each query carries the end user's identity to the IRC, -keeping per-user credential vending and per-user authorization intact. Set -`gravitino.iceberg.rest-catalog.session` explicitly to override it. See +The connector sets `iceberg.rest-catalog.session=USER` automatically when both hold: + +- `gravitino.client.session.forwardUser=true` +- the IRC authenticates with OAuth2 — either `gravitino.client.authType=oauth2`, or + `gravitino.iceberg.rest-catalog.security=OAUTH2` (or `trino.bypass.iceberg.rest-catalog.security` Review Comment: Why do you use `OAUTH2` and `oauth2` at the same time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
