zhang-arvin commented on PR #12571: URL: https://github.com/apache/gravitino/pull/12571#issuecomment-5616931850
Thanks @ss666 for the thorough review! All four points are now addressed in the latest push: 1. **doNothing() stubbing** - removed the unnecessary stub entirely (Mockito mocks already no-op void methods) 2. **TEST_CONNECTION audit mapping** - added `AuditLog.Operation.TEST_CONNECTION`, the v1 `fromEvent` mapping for `TestConnectionEvent`/`TestConnectionFailureEvent`, and the v2 `CompatibilityUtils.OPERATION_TYPE_MAP` entry, so connection-test events record as TEST_CONNECTION in both SimpleFormatter and JsonAuditFormatter 3. **NameIdentifier overload** - implemented the pre/success/failure event dispatching in `testConnection(NameIdentifier)` and `testConnection(NameIdentifier, CatalogChange...)`, removing both TODOs 4. **Formatting** - spotlessApply ran clean; bump scripts updated Also added tests for the single-argument overload (success + failure paths) in `TestCatalogEvent`. CI was also failing earlier on access-control-IT due to the same spotless issue - that is fixed too. The branch is also rebased onto the latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
