shaoyu-li commented on code in PR #13058:
URL: https://github.com/apache/gravitino/pull/13058#discussion_r3985822717
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/GenericCatalogOperations.java:
##########
@@ -233,7 +250,16 @@ public Table createTable(
Index[] indexes)
throws NoSuchSchemaException, TableAlreadyExistsException {
Schema schema = loadSchema(NameIdentifier.of(ident.namespace().levels()));
- String tableLocation = calculateTableLocation(schema, ident, properties);
+ String tableLocation =
+ validateProvisionedLocation(
+ tableLocationProvider.provisionTableLocation(
Review Comment:
Done in 29a4ea9. The format check and the `tableOpsCache` lookup now happen
before provisioning, so
a request this catalog rejects on its own never costs the provider an
allocation. A creation request
carrying its own non-blank `location` bypasses the provider entirely, and
`isExternal()` is on the
context. No compensating unprovision on a failed create, for the reason
above; it is written up as
a known limitation in the interface contract and in the catalog docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
