lasdf1234 commented on PR #12942: URL: https://github.com/apache/gravitino/pull/12942#issuecomment-5664180416
The spec_id parameter is documented as optional with default “the table’s current spec”, but operators still have no way to know which integer to pass (0 vs 1 vs …). That is too abstract for anyone who evolved the table from day partitioning to hour partitioning. Could we add a short “How to find spec_id” note in the Parameters section (and ideally in the user-facing CLI docs that #12937 owns)? Something like: Omit spec_id unless you need to rewrite against a non-default spec. Omission uses Iceberg’s current spec and only consolidates small manifests. Do not guess 0/1. Discover IDs from table metadata (default-spec-id / DESCRIBE EXTENDED) or SELECT DISTINCT partition_spec_id FROM <table>.manifests. Pass the id of the spec you want new manifests written with (usually the current one, e.g. hour after a day→hour evolution). Also worth one sentence of clarification: spec_id does not filter which manifests are rewritten. The procedure still rewrites all manifests of the current snapshot; spec_id only chooses the partition spec used for the new manifests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
