lasdf1234 commented on PR #13153: URL: https://github.com/apache/gravitino/pull/13153#issuecomment-5674407109
One convention gap vs the other built-in Iceberg jobs (IcebergExpireSnapshotsJob, IcebergRewriteDataFilesJob, etc.): 1. Template environments — please add .withEnvironments(GravitinoAuthSettings.jobTemplateEnvironments()) so GRAVITINO_AUTH_* placeholders are available when server auth is enabled. 2. REST catalog auth — in main(), call IcebergJobUtils.applyIcebergRestAuth(sparkBuilder, catalogName, null) before creating the Spark session (same as expire/rewrite jobs). 3. Runtime check — after getOrCreate(), call IcebergJobUtils.requireIcebergSparkRuntime() so missing iceberg-spark-runtime fails fast with a clear error. Without these, the job may work in local Hadoop tests but fail in deployments that use Gravitino auth or authenticated Iceberg REST catalogs. Could you align with the sibling jobs in a follow-up commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
