yuqi1129 opened a new pull request, #13347:
URL: https://github.com/apache/gravitino/pull/13347

   ### What changes were proposed in this pull request?
   
   Read Doris table comments from `SHOW CREATE TABLE` when loading tables. Add 
tests for a user comment, a table without a comment, and comment parsing, plus 
integration coverage for Doris 1.2 and 4.x.
   
   ### Why are the changes needed?
   
   On affected Doris versions, JDBC metadata reports the table engine (`OLAP`) 
as `REMARKS`. The connector currently treats a nonempty `REMARKS` value as the 
user comment, so a table created with a comment loads with the wrong comment.
   
   Fix: #13346
   
   ### Does this PR introduce _any_ user-facing change?
   
   Loaded Doris tables return the actual user comment instead of `OLAP`. No API 
or property key changes.
   
   ### How was this patch tested?
   
   - `./gradlew spotlessApply :catalogs:catalog-jdbc-doris:test -PskipITs 
-PskipDockerTests=true -PskipWeb=true --console=plain`
   - `./gradlew spotlessApply :catalogs:catalog-jdbc-doris:test --tests 
org.apache.gravitino.catalog.doris.operation.TestDorisTableCommentOperations 
-PskipITs -PskipDockerTests=true -PskipWeb=true --console=plain`
   - `./gradlew :catalogs:catalog-jdbc-doris:test --tests 
org.apache.gravitino.catalog.doris.integration.test.CatalogDorisIT.testTableCommentRoundTrip
 -PskipDockerTests=false -PdorisMultiVersionTest -PskipWeb=true --console=plain`
   
   The Doris 4.x integration test was added but could not complete locally 
because its container startup stalled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to