neoLsH commented on PR #13250: URL: https://github.com/apache/gravitino/pull/13250#issuecomment-5749586042
Thanks @jerryshao — really appreciate you going through each point. Glad the byte-cap one landed. On #2 you're right, I hadn't thought it all the way through — even a single method is still two sequential reads underneath, so calling it atomic was overselling it, and the two-method shape is simpler without hurting debuggability. Good reminder for me to separate what the API shape implies from what's actually happening on disk. The calls on #3 and #4 make sense too — leaving them as known local-executor limitations and giving multi-node its own follow-up keeps this one focused. Honestly this back-and-forth taught me a fair bit: where the local job executor's boundaries actually sit, and how to judge what belongs in a single PR versus what deserves its own. Thanks for taking the time to lay out the reasoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
