jiangxt2 commented on code in PR #12826:
URL: https://github.com/apache/gravitino/pull/12826#discussion_r4057325573
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -1745,6 +1751,27 @@ private List<Index> querySecondaryIndexes(
type);
continue;
}
+
+ Map<String, String> parameterProperties = Collections.emptyMap();
+ if (indexType == Index.IndexType.DATA_SKIPPING_SET) {
+ try {
+ parameterProperties =
+ parseIndexPropertiesForQuery(indexType, parameterSource,
name, !includesTypeFull);
Review Comment:
I moved SET parameter parsing to after parseIndexFields succeeds, so indexes
with expressions Gravitino cannot represent are skipped before their SET
parameters are validated. SET metadata is still validated for supported
expressions. I added a regression test for an unsupported expression with
set(2147483648) and kept malformed metadata coverage for a supported expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
