lasdf1234 commented on PR #13354: URL: https://github.com/apache/gravitino/pull/13354#issuecomment-5757056691
> copies hidden/reserved flags that each connector owns, with nothing tying the two together (verified by: compare Thanks for the review. Those findings are about the earlier RegisteredPropertyKeys approach, which this PR no longer uses. We dropped that design because it made core a second source of hidden / reserved for every official key. Keys a catalog never declared, such as Glue's pass-through comment and EXTERNAL, were omitted from properties(), and any connector key defined outside core had to be hard-coded into the registry or catalog load failed. A later change to a connector's hidden flag would also not update the copied registry entry. The bug is narrower. s3-access-key-id is already defined as hidden=false in S3PropertiesMetadata. Iceberg declares it, so the value stays cleartext. Glue does not, and the name contains access, so the same value is fuzzy-masked as ******. This patch only merges the existing S3, OSS, Azure, GCS, COS, and AWS PropertyEntry objects into BaseCatalogPropertiesMetadata. A catalog that already declares a key keeps its own entry. HiddenPropertyMaskUtils, BasePropertiesMetadata, and SecretPropertyUtils are unchanged, so omission still follows the catalog's own metadata. Every merged key is optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
